Fix VP9 decoding on iOS #269
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
- Coverage 86.22% 84.10% -2.12%
==========================================
Files 22 24 +2
Lines 1749 1950 +201
==========================================
+ Hits 1508 1640 +132
- Misses 204 253 +49
- Partials 37 57 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aler9
force-pushed
the
fix/vp9
branch
3 times, most recently
from
0532c6a
to
fdfd0c8
Compare
|
Thank you @aler9! I am in full support of this, happy to review w/e you are ready. If Flexible mode doesn't have value (and is a burden) we could drop it. |
aler9
force-pushed
the
fix/vp9
branch
4 times, most recently
from
d7dea6e
to
417bf25
Compare
The current implementation of the VP9 payloader produces payloads that are not compatible with iOS. This is because the payloader provides only the muxing strategy called "flexible mode". According to the VP9 RFC draft, there are two ways to wrap VP9 frames into RTP packets: the "flexible mode" and the "non-flexible mode", with the latter being the preferred one for live-streaming applications. In particular, all browsers encodes VP9 RTP packets in the "non-flexible mode", while iOS supports decoding RTP packets in this mode only, and this is probably a problem shared by other implementations. This patch improves the VP9 payloader by adding support for the "non-flexible mode". The "flexible mode" is retained and a flag is provided to perform the switch between the two modes.
|
Hello @Sean-Der, now everything is ready for review, thanks for being available. |
|
LGTM @aler9! Thank you so much :) |
Description
The current implementation of the VP9 payloader produces payloads that are not compatible with iOS. This is because the payloader provides only the muxing strategy called "flexible mode".
According to the VP9 RFC draft, there are two ways to wrap VP9 frames into RTP packets: the "flexible mode" and the "non-flexible mode", with the latter being the preferred one for live-streaming applications. In particular, all browsers encodes VP9 RTP packets in the "non-flexible mode", while iOS supports decoding RTP packets in this mode only, and this is probably a problem shared by other implementations.
This patch improves the VP9 payloader by adding support for the "non-flexible mode". The "flexible mode" is retained and a flag is provided to perform the switch between the two modes.
Reference issue
bluenviron/mediamtx#3060